Skip to content

fix: check if attribute code exists in the case we have no attribute id #40459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cmuench wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

fix: check if attribute code exists in the case we have no attribute id #40459

cmuench wants to merge 1 commit into from
+28 −5

Conversation

@cmuench
Copy link
Contributor

@cmuench cmuench commented Jan 22, 2026 •
edited
Loading

Description (*)

Missing attribute_id handling: Previously, if attribute_id was missing from the payload (even if attribute_code was in the URL), the system attempted to create a new attribute, resulting in a duplicate code error. This fix resolves the attribute_id from the existing attribute code if needed.

Invalid Option ID Crash: If the payload contained numeric option IDs that did not exist in the database (e.g., during migration or copy-paste between envs), it caused a SQL Integrity Constraint Violation. This fix validates provided option IDs against the database and treats invalid/missing IDs as new options to be created.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes REST API Attribute Update fails without attribute_id #40458

Manual testing scenarios (*)

  • Validated that PUT /V1/products/attributes/:code works without attribute_id in body. Good testable with "color" attribute.
  • Ran unit tests: vendor/bin/phpunit app/code/Magento/Catalog/Test/Unit/Model/Product/Attribute/RepositoryTest.php

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 22, 2026

Hi @cmuench. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@cmuench cmuench force-pushed the bugfix/attribute-put-rest-api branch from 114a8e5 to a0348c6 Compare January 22, 2026 11:55
@cmuench
Copy link
Contributor Author

cmuench commented Jan 22, 2026

@magento run Unit Tests

@cmuench
Copy link
Contributor Author

cmuench commented Jan 24, 2026

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 27, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Pull Requests Dashboard
Status: Pending Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REST API Attribute Update fails without attribute_id

2 participants

@cmuench @engcom-Bravo